Skip to content

feat: add KML#772

Open
lenderom wants to merge 10 commits intomainfrom
feat/add-kml
Open

feat: add KML#772
lenderom wants to merge 10 commits intomainfrom
feat/add-kml

Conversation

@lenderom
Copy link
Copy Markdown
Member

@lenderom lenderom commented Mar 16, 2026 •
edited
Loading

Add information for the new FIP member KML

@lenderom lenderom added content Improvements or additions to the content (countries, news, operators, general content) operator::kml labels Mar 16, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 16, 2026 •
edited
Loading

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 510832f
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/69c2b74fe95b0c0007d42c64
😎 Deploy Preview https://deploy-preview-772--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@Willy102
Copy link
Copy Markdown
Contributor

Willy102 commented Mar 21, 2026

@lenderom I added the news article for KML. Next step would be to add images for the KML page and news article and the icon. Could you do this?

@lenderom
Copy link
Copy Markdown
Member Author

lenderom commented Mar 22, 2026

@lenderom I added the news article for KML. Next step would be to add images for the KML page and news article and the icon. Could you do this?

https://discord.com/channels/1250522473188032512/1481980559034155080/1485332974495993907

@lenderom lenderom marked this pull request as ready for review March 22, 2026 18:25
therobrob
therobrob previously approved these changes Mar 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@therobrob therobrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add at least a photo for the news article, as already mentioned by @lenderom in discord :)

content/operator/kml/index.de.md
Comment on lines +20 to +21
{{< fip-validity type="fip-coupon" status="valid" >}}
{{< fip-validity type="fip-reduced-ticket" status="valid" >}}
Copy link
Copy Markdown
Member

@therobrob therobrob Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we disable the lightbox until we have detailed information?

Copy link
Copy Markdown
Member Author

@lenderom lenderom Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's fine for now to be honest 😅

Copy link
Copy Markdown
Member

@MoritzWeber0 MoritzWeber0 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also say that it's fine. We hopefully have some information soon and then we don't forget to enable the dialog once we have the information.

Copy link
Copy Markdown
Member

@MoritzWeber0 MoritzWeber0 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have the information for GB already, so we could just add it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoritzWeber0 MoritzWeber0 MoritzWeber0 left review comments

@therobrob therobrob therobrob left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

content Improvements or additions to the content (countries, news, operators, general content) operator::kml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lenderom @Willy102 @MoritzWeber0 @therobrob